Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 57f1217

Browse files
committedSep 14, 2020
the filenames use the separator - instead of _
1 parent 06c32c0 commit 57f1217

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed
 

‎tests/test-rmd.R

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,27 +29,27 @@ if (Sys.getenv('NOT_CRAN') == 'true') local({
2929
# footnotes are parsed and moved correctly
3030
## deleted from last section
3131
if (any(readLines("rmd/subsection-footnotes-2.html") == '<div class="footnotes">')) {
32-
stop('Failed to parse and delete the footnotes in parse_footnotes.Rmd')
32+
stop('Failed to parse and delete the footnotes in parse-footnotes.Rmd')
3333
}
3434
## footnote one is moved to first section
3535
if (!any(readLines('rmd/test-footnote.html') == '<div class="footnotes">') ||
3636
!any(grepl('id="fn1"', readLines('rmd/test-footnote.html')))) {
37-
stop('Failed to move the footnotes back to subsection 1 in parse_footnotes.Rmd')
37+
stop('Failed to move the footnotes back to subsection 1 in parse-footnotes.Rmd')
3838
}
3939
## footnote two is moved to second section
4040
if (!any(readLines('rmd/subsection-footnotes-1.html') == '<div class="footnotes">') ||
4141
!any(grepl('id="fn2"', readLines('rmd/subsection-footnotes-1.html')))) {
42-
stop('Failed to move the footnotes back to subsection 1 in parse_footnotes.Rmd')
42+
stop('Failed to move the footnotes back to subsection 1 in parse-footnotes.Rmd')
4343
}
4444
# multiline footnote is also moved
4545
if (!any(readLines('rmd/subsection-footnotes-1.html') == '<div class="footnotes">') ||
4646
!any(grepl('id="fn3"', readLines('rmd/subsection-footnotes-1.html')))) {
47-
stop('Failed to move the footnotes back to subsection 1 in parse_footnotes.Rmd')
47+
stop('Failed to move the footnotes back to subsection 1 in parse-footnotes.Rmd')
4848
}
4949

5050
# number sections now works in markdown_document2
5151
if (!any(readLines("rmd/number-sections.md") == "1.1 subsection 1") ||
5252
!any(grepl("<a href=.*>2.1</a>", readLines("rmd/number-sections.md")))) {
53-
stop("Something wrong in number_sections.Rmd")
53+
stop("Something wrong in number-sections.Rmd")
5454
}
5555
})

2 commit comments

Comments
 (2)

GangminLi commented on Oct 5, 2020

@GangminLi

I am sure thsi si the right place to leave a comment. But I had a problem with split files with sections. In my book I have "Sumamry" and "Exercises" at the end of each chapter. The Knitr will complaint that the section has the same name. The output HTML will have a problem too. I guess you need to make name with index of Chapter or something similar. Bookdown has to address this problem because it is a common schema for a textbook. Thanks fo rthe great work. Maybe could think of do another textbookdown!

cderv commented on Oct 5, 2020

@cderv
Collaborator

Hi @GangminLi , this unfortunatly has nothing to do with this commit.

Please ask your question on https://community.rstudio.com or Stack overflow.

And if you have a feature request, open an issue in GH instead of a comment on commit. Thank you !

Issue guide is here: https://yihui.org/issue/

Please sign in to comment.