Skip to content

CLN: Use dedup_names in all instances where duplicate column names are renamed #50371

Open
@datapythonista

Description

@datapythonista
Member

In #50370 the function dedup_names has been moved to pandas.io.common so it can be reused by any reader dealing with duplicate column names. The function can be expanded in the future to allow custom renaming patterns, so it should be used by any reader, to make sure we keep consistency with the behavior (as well as avoid duplicate code). There is at least one instance identified in #50370 where a different implementation is used to rename the duplicate columns. We should call dedup_names instead, and in case other alternative implementations exist, find them and also call dedup_names.

Activity

muddi900

muddi900 commented on Dec 24, 2022

@muddi900

take

deleted a comment from jayam30 on Feb 16, 2023
leftful

leftful commented on Mar 1, 2023

@leftful

Hi @muddi900 how are you going with this issue?
Happy to take over if you don't have the time :)

muddi900

muddi900 commented on Mar 1, 2023

@muddi900

You can take over if the maintainers allow.

removed their assignment
on Mar 1, 2023
leftful

leftful commented on Mar 2, 2023

@leftful

take

shteken

shteken commented on Apr 22, 2023

@shteken
Contributor

Hi @RhysJohnLewis how are you going with this issue?
Happy to take over if you don't have the time :)

leftful

leftful commented on Apr 24, 2023

@leftful

@shteken please do. I have not had the time.

removed their assignment
on Apr 24, 2023

27 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Participants

    @hamedgibago@datapythonista@LifeAsPixels@shteken@muddi900

    Issue actions

      CLN: Use dedup_names in all instances where duplicate column names are renamed · Issue #50371 · pandas-dev/pandas