-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added spec for opkg PURL type #279
base: main
Are you sure you want to change the base?
Conversation
db24fd3
to
1cc8ab7
Compare
Unrelatedly, I moved the |
@@ -556,7 +573,6 @@ Other candidate types to define: | |||
- ``nim`` for Nim packages: | |||
- ``nix`` for Nixos packages: | |||
- ``opam`` for OCaml packages: | |||
- ``openwrt`` for OpenWRT packages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this line removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is re-adding this all that is remaining to get get this approved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This work might be abandoned, considering taking it over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the scope of a PR simple - one change at a time.
just revert this very change, please.
Thank you for your PR @oblivia-simplex . I noticed that you have not replied to @jkowalleck 's 2024-10-17 question. When you have the chance, could you please merge the latest |
@@ -556,7 +573,6 @@ Other candidate types to define: | |||
- ``nim`` for Nim packages: | |||
- ``nix`` for Nixos packages: | |||
- ``opam`` for OCaml packages: | |||
- ``openwrt`` for OpenWRT packages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the scope of a PR simple - one change at a time.
just revert this very change, please.
I wrote up a spec for the
opkg
PURL type, which I think we should use as a root type instead ofopenwrt
(which is currently stubbed out but not further specified in thepackageurl-go
repo, for example). I suggest lettingopenwrt
act as a namespace foropkg
PURLs, which is consistent with what the spec already has forapk
PURLs, as explained inPURL-TYPES.rst
.One potentially contentious detail in my
opkg
PURL spec is the qualifier key I calledset
, which corresponds to whatopkg
calls "repositories". I choseset
as a name for this field rather thatrepository
orrepo
to avoid confusion with therepository_url
field. The "sets" in question, in the case of OpenWrt'sopkg
distribution, includeThe key
set
was chosen by analogy with OpenBSD's "sets" (collections of related packages, with names like "base", "game", "font", etc.). I'm not particularly wedding to this choice, though, and would welcome alternative suggestions.