Skip to content

fix(Card/Drawer/Modal): prevent scrollbars overflow #4368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 24, 2025

Conversation

Sepush
Copy link
Contributor

@Sepush Sepush commented Jun 17, 2025

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The command palette's bottom-right border-radius is obscured by the scrollbar.

before
image
image

after
image
image

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
Siteproxy
@Sepush Sepush requested a review from benjamincanac as a code owner June 17, 2025 11:21
Sepush added 2 commits June 17, 2025 19:40
Copy link

pkg-pr-new bot commented Jun 17, 2025

npm i https://pkg.pr.new/@nuxt/ui@4368

commit: a20059d

@benjamincanac
Copy link
Member

I think it would be better to set an overflow-hidden on the modal's content, the CommandPalette should not have a rounded class to adapt to its parent.

@Sepush
Copy link
Contributor Author

Sepush commented Jun 17, 2025

I think it would be better to set an overflow-hidden on the modal's content, the CommandPalette should not have a rounded class to adapt to its parent.

Make sense,allready done it.

@benjamincanac benjamincanac changed the title fix(command-palette): keep rounded fix(Card/Modal): prevent scrollbars overflow Jun 24, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
up
@benjamincanac benjamincanac changed the title fix(Card/Modal): prevent scrollbars overflow fix(Card/Drawer/Modal): prevent scrollbars overflow Jun 24, 2025
Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Sepush! 😊

I added it on the Drawer component as well when the inset prop is true.

@benjamincanac benjamincanac merged commit c3adc38 into nuxt:v3 Jun 24, 2025
6 checks passed
@Sepush Sepush deleted the fix/cmd-p branch June 24, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants