Skip to content

Buttons' appearance in disabled fieldset #5562

New issue
New issue
Open
#5563
Open
Buttons' appearance in disabled fieldset#5562
#5563
@datvm

Description

@datvm
datvm
opened on Apr 2, 2024
Contributor

What is affected?

Component

Description

When a button or icon button is in a disabled fieldset, it correctly does not trigger click event. However, the appearance is not changed to match:

image

Reproduction

Lit Playground

Workaround

We have to manually keep track of the buttons' state and disable/enable each of them.

Is this a regression?

No or unsure. This never worked, or I haven't tried before.

Affected versions

1.4.0

Browser/OS/Node environment

Browser: Google Chrome Version 123.0.6312.86 (Official Build) (64-bit)

OS: Windows 11

Activity

asyncLiz

asyncLiz commented on Apr 2, 2024

@asyncLiz
asyncLiz
on Apr 2, 2024
Collaborator

This is probably due to button not implementing formDisabledCallback()

datvm

datvm commented on Apr 3, 2024

@datvm
datvm
on Apr 3, 2024 · edited by datvm
ContributorAuthor

Interesting, I believe this is related to #5049. I thought it was completed because the click behavior is working correctly with fieldset. Right now the styling is depending on [disabled]. I think it should be changed to :disabled instead.

I have created 2 PRs. If both PRs are approved it should fix this and #5049 as well.

datvm
linked a pull request that will close this issue on Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @datvm@asyncLiz

      Issue actions
        Buttons' appearance in disabled fieldset · Issue #5562 · material-components/material-web