Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nighly version notice to welcome page #5799

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

shun2wang
Copy link
Contributor

@shun2wang shun2wang commented Feb 26, 2025

Reopened #5797 which was closed by accidently force push...

Fix: https://github.com/jasp-stats/INTERNAL-jasp/issues/2739

We using a branch name to detecting if it is a nightly build. before merge this we should fix Git detached HEAD of this repo.

Now in the welcom page for both developers and users convenient to know whether they are working with a nightly under testing. because we did see in the issue that some users "accidentally" used the test version in the production environment.

@JorisGoosen
Copy link
Contributor

The nightlies page does start with a warning:
image
Maybe I should just make the "Use at your own risk" way bigger?

There is also the problem of HEAD indeed, the settings of buildbot look sensible to me and @RensDofferhoff but we have no idea why it keeps doing that.

Also there is still the problem where sometimes we did a special release for only flatpak from a different branch than stable/development which would not work well with this PR.

I do agree it would be awesome if the nightly would look different from the release.

I guess if the release always follows the pattern of:

  • development changes go to stable
  • we build the release from stable

@boutinb @RensDofferhoff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants