Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monetary columns and locale sensitive number display #5794

Open
wants to merge 21 commits into
base: development
Choose a base branch
from
+1,123 −668
Open

Monetary columns and locale sensitive number display #5794

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
63eebd6
some rudimentary support for monetary columns
JorisGoosen Feb 11, 2025
5814d79
add support for formatting via locale
JorisGoosen Feb 12, 2025
318f956
numbers are translated through qt now, which avoids problems with str…
JorisGoosen Feb 12, 2025
c2f48a8
update double labels after language change
JorisGoosen Feb 12, 2025
74449bd
mention something about restarting jasp
JorisGoosen Feb 12, 2025
9e8db8a
fighting with some qml components...
JorisGoosen Feb 12, 2025
378d7cc
attempt to make all qml use localized doubles etc
JorisGoosen Feb 18, 2025
902b005
remove integer array thing from textinputbase and make it handle perc…
JorisGoosen Feb 19, 2025
fa56c01
rewrite the html js formatting code a bit
JorisGoosen Feb 19, 2025
b820dca
ok money now seems to respect locale
JorisGoosen Feb 19, 2025
6ecedcd
now the currency and some numbers are formatted correctly even on sta…
JorisGoosen Feb 19, 2025
39a0c22
all numbers in the table now seem to be localized
JorisGoosen Feb 19, 2025
6ff9056
latenight problems get latenight solutions
JorisGoosen Feb 19, 2025
fa6dd66
make a setting to switch back to the US setting
JorisGoosen Feb 19, 2025
9fa82f6
make sure comparing results uses english, us locale and doesnt ask fo…
JorisGoosen Feb 20, 2025
7501ae3
remove debug print from js
JorisGoosen Feb 20, 2025
d84f855
add #include <functional>
JorisGoosen Feb 20, 2025
13065b3
make sure all string -> double/int also uses locale
JorisGoosen Feb 20, 2025
72ca4dc
add support for choosing the locale you want instead of the one belon…
JorisGoosen Feb 26, 2025
2ef0ccd
sort on toLower to find things a bit easier
JorisGoosen Feb 26, 2025
f56b0ec
ah and also maybe store the changed settings...
JorisGoosen Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
mention something about restarting jasp
  • Loading branch information
@JorisGoosen
JorisGoosen committed Feb 18, 2025
commit 74449bdfe3e831a22f5e1371b48d1abd729ef589
4 changes: 2 additions & 2 deletions Desktop/components/JASP/Widgets/FileMenu/PrefsUI.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ ScrollView
DropDown
{
id: languages
label: qsTr("Choose language ")
label: qsTr("Choose language")
source: languageModel
startValue: languageModel.currentLanguage
onValueChanged: languageModel.currentLanguage = value
Expand All @@ -200,7 +200,7 @@ ScrollView
label: qsTr("Use system locale")
checked: languageModel.useSystemLocale
onCheckedChanged: languageModel.useSystemLocale = checked
toolTip: qsTr("Use system locale for display of numbers, dates, times and currency")
toolTip: qsTr("Use system locale for display of numbers, dates, times and currency. Might require a restart of JASP to be effective.")
}


Expand Down