Adding levels #5789
Adding levels #5789
Conversation
8583229 to
ded1fd5
Compare
|
The levels check should now work and get triggered |
|
If you have an analysis that displays the levels of a variable, when adding a label, it adds this label in the result. But if you uncheck another label (in the filter column), then this label and the newly created label is removed. I don't think this is the right behavior. I think per default, all the checked labels should be used by the analysis. I find the 'Only filtered levels' button in the Filter editor quite disturbing: this button has a GUI behavior which is not seen elsewhere in JASP: its tooltip explains what happens if you click on it, not what means 'Only filtered levels'. That it is actually a button is already not trivial, as it is integrated on the bottom bar of the filter editor. I think I would prefer a checkbox 'Keep all levels' with a tootip explaining what it means to have it on or off. |
|
Or we just disable it by default and its all clear |
|
OK so I just played around with the latest version and like it! So for example, when we have facFive (with some edits), and we add a lvl that denoted missingness (999), I would want to keep all levels by default (after filtering out level 2) in my output: |
|
But now, if you filter out one label, the label is still in the table:
You have to go to the filter editor to set it to 'Only filtered levels'. |
|
OK that's a good point; I see now that the discussion is about what happens after the filter is applied and then I understand that we do droplevels (i.e., the user requests filtering, so we make sure that everything gets filtered properly). I think it makes sense that when a user filters out facFive "2", then there should be no output for facFive "2". So then the default will stay at "Only filtered levels" when a filter is applied, and "keep all levels" when a filter is not applied? With the user being able to toggle that box whenever they want the other option? edit: OK so I would want to propose a middle ground - only droplevels for those levels that have been specifically filtered out by the user. That means, in the screenshot below, that only level 2 should have been dropped, while 6 and 7 (which still have a checkmark) are shown. Is this something that is feasible/reasonable? Because I think that aligns most closely to what the user would expect based on how they have filtered. Also, would it make sense to also have this button (synced) in the variable settings menu where these tickmarks can be placed? |
Bruno suggested this too and it sounds reasonable for the label-filters. And then there is still the problem of what to do about the other filters. I mean, I could completely remove using the function |
No, the default is "keep levels". If they dont want that they can drop levels. |
I can add the same button there somewhere yes. |
|
Maybe its more logical to put the dropping-levels property per column? But then as soon as someone manually adds a level we can switch to "keep levels" right there and then for that column only. And Id remove the button from the filterwindow. |
I find it a good solution! It makes sense. |
|
I found another issue: if you remove one level, it updates the analysis, but if you undo it, it does not update the analysis. |
love it! |
|
Ok the button works but there is a weird issue with the filter-button not updating correctly. So I guess I should also fix that while im at it |
entry boxes for level addition adding and removing labels now works
default is off, older jaspfiles will have it on by default tooltip now describes what its doing not what it will do after clicking
here we can store the name of the filter to load, or nothing if we just want everything. This can then also be taken into account when writing the data.
this involves setting a name for the default filter right now the selection is between no filter and the default filter, but this can be extended easily later
should make jasp-stats/jasp-issues#2553 a little bit more solved also
e02bdf7 to
686439e
Compare
|
Ok this is ready for review again and Ive also triggered some new builds |
|
Ooh no wait I forgot something |
- when disabling a label (filterAllows) and dropLevels==noChoice it becomes drop levels - when adding a label and dropLevels==noChoice it becomes keep levels - default when noChoice is drop levels
|
Alright, now Ive also actually implemented the noChoice->drop/keep behaviour for the button. It is ready for review again |
…with those buttons Also makes tooltips on disabled Rectangular/RoundedButtons show
As requested by @JohnnyDoorn and many others, here is support for manually adding and removing levels in JASP.
This also adds a button to the filter, this to control whether all levels should be passed on or not.
It does exactly what it says on the tin.
Older jaspfiles loaded will have it on by default, so dropping levels.
While fresh workspaces will keep levels by default so useradded levels arent dropped immediately...
Ive kept the old default behaviour of dropping levels as the default. But to make the transition easier it is only used in R *if there is any row that is filtered out!*.So, if the filter is still the default, or it is a nonsensical filter that passes everything it will not drop levels that are missing from the data (which would be those manually added by the user).
If the filter has at least one row filtered out it will instead respect the property "dropLevels" which will, if enabled, drop any levels no longer (or never) in the data.