Skip to content

Extend Sign in with Apple OAuth Provider - add ability to set full name #7603

Open
@mikehardy

Description

@mikehardy
Collaborator

With release 10.7.0 of firebase-ios-sdk the auth module gained the ability to set the full name for sign in with apple: https://firebase.google.com/support/release-notes/ios#authentication_7

The OAuth provider likely needs an extension to accept the new parameter (hopefully optional...at least at the javascript layer here) and then call the new API signature in the underlying firebase-ios-sdk

Likely location to add new parameter for the full name in the Apple OAuth credential creation:

static credential(token, secret) {
return {
token,
secret,
providerId,
};

Likely location to swap out the current more generic OAuthProvider call for the apple-specific one mentioned here firebase/firebase-ios-sdk#4393 (comment):

credential = [FIROAuthProvider credentialWithProviderID:provider
IDToken:authToken
rawNonce:authTokenSecret];

PRs welcome! Confirmed that it is tested and working locally critical...

As mentioned in #4046

Activity

Claeysson

Claeysson commented on Feb 5, 2024

@Claeysson

This is an essential feature since Apple rejects apps that don't set the user name based on what is provided by the Apple authentication process.

mikehardy

mikehardy commented on Feb 5, 2024

@mikehardy
CollaboratorAuthor

Hi there! In an open source contexts, essential features that are important to you may be implemented at any time via a pull request - I review them all and merge everything that looks good as fast as possible with quick releases

Otherwise, you'll have to be patient and hope some kind fellow developer implements the thing you need, but that will not be in your control

github-actions

github-actions commented on Mar 4, 2024

@github-actions

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

added
Type: StaleIssue has become stale - automatically added by Stale bot
on Mar 4, 2024
added
help: good-first-issueIssues that are non-critical issues & well defined for first time contributors.
and removed
Type: StaleIssue has become stale - automatically added by Stale bot
on May 2, 2024
siquick

siquick commented on May 3, 2024

@siquick

This would be a great addition to the library.

github-actions

github-actions commented on Jul 15, 2024

@github-actions

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

github-actions

github-actions commented on Aug 13, 2024

@github-actions

Hello 👋, to help manage issues we automatically close stale issues.

This issue has been automatically marked as stale because it has not had activity for quite some time.Has this issue been fixed, or does it still require attention?

This issue will be closed in 15 days if no further activity occurs.

Thank you for your contributions.

added
Keep Openavoids the stale bot
and removed
Type: StaleIssue has become stale - automatically added by Stale bot
on Aug 13, 2024
thanhnd1o2

thanhnd1o2 commented on Oct 25, 2024

@thanhnd1o2

i have the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Keep Openavoids the stale bothelp: good-first-issueIssues that are non-critical issues & well defined for first time contributors.help: needs-triageIssue needs additional investigation/triaging.type: enhancementImplements a new Feature

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @mikehardy@siquick@russellwheatley@thanhnd1o2@Claeysson

      Issue actions

        Extend Sign in with Apple OAuth Provider - add ability to set full name · Issue #7603 · invertase/react-native-firebase