Skip to content

Copied hash ranges are backwards #2246

Open
@Desdaemon

Description

@Desdaemon

Describe the bug
I've been using the hash range copy feature introduced in #1288 to do a lot of cherry-picking, a large majority of which are consecutive ranges. However I can't use the range as-is and would have to manually reverse it myself, since marks are sorted by latest first. Thank you!

EDIT(2024/06/28): I've noticed that even for non-consecutive ranges the order is reversed. If the order of marks is not depended on anything else in gitui, I think it's desirable to reverse it for ease of use.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the Log screen
  2. Mark a consecutive range of commits and copy to clipboard
  3. Try to git cherry-pick with the copied range
  4. error: empty commit set passed

Expected behavior
It would be more convenient for hash ranges to be sorted from oldest to latest.

Screenshots
N/A

Context

  • OS/Distro + Version: Pop_OS 22.04
  • GitUI Version: nightly 2024-05-19
  • Rust version: 1.78.0

Additional context
N/A

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @Desdaemon

      Issue actions

        Copied hash ranges are backwards · Issue #2246 · gitui-org/gitui