When the terminal is insufficient to display all the commands, the cmdbar_bg configuration color does not fully take effect. #2347
Description
Describe the bug
In my terminal, Kitty, I've customized the font size. In the GitUI window, when the commands do not fully display on one line, and I press . to show more commands, the background color of these additional commands does not match the cmdbar_bg color configured in ~/.config/gitui/theme.ron.
录屏 2024-08-30 11-59-18.webm
To Reproduce
Steps to reproduce the behavior:
- adjust the terminal font size to ensure that the command cannot be displayed in one line
- vim ~/.config/gitui/theme.ron
(
cmdbar_bg: Some("#FFFFFF"),
)
- execute
gituicommand then express.to show more command
4 . See the difference two command line
Expected behavior
The background color of the two lines of commands is the color configured by cmdbar_bg in ~/.config/gitui/theme.ron.
Screenshots
Context (please complete the following information):
- OS/Distro + Version: [
CachyOS Linux x86_64 Linux 6.6.47-1-lts] - GitUI Version [
gitui nightly 2024-06-02 (95e1d4d)] - Rust version: [
rustc 1.80.1 (3f5fd8dd4 2024-08-06)]
Metadata
Metadata
Assignees
Type
Projects
Milestone
Relationships
Participants
Activity
[-]When the terminal font is insufficient to display all the commands, the cmdbar_bg configuration color does not fully take effect.[/-][+]When the terminal is insufficient to display all the commands, the cmdbar_bg configuration color does not fully take effect.[/+]extrawurst commentedon Aug 30, 2024
interesting. good catch!
wugeer commentedon Aug 30, 2024
@extrawurst hello, maybe I have discovered why this problem occurs. I would like to ask what is the meaning of the fields
cmdbar_extra_lines_bgandcmdbar_bgunderstruct Theme? From my personal perspective,cmdbar_extra_lines_bgactually does not need to exist, the background of cmdbar should remain consistent.I will submit a PR to fix this issue later. :)