Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .containerfile extension #6799

Closed
gnat opened this issue Apr 17, 2024 · 3 comments · Fixed by #7056
Closed

Add support for .containerfile extension #6799

gnat opened this issue Apr 17, 2024 · 3 comments · Fixed by #7056
Assignees

Comments

@gnat
Copy link

gnat commented Apr 17, 2024

Containerfile is currently an alias for Dockerfile great!

blah.Dockerfile works but blah.Containerfile does not.

@lildude lildude changed the title Bug: Handle *.Containerfile the same way as *.Dockerfile Add support for .Containerfile extension Apr 17, 2024
@lildude
Copy link
Member

lildude commented Apr 17, 2024

If the extension is popular enough to meet our usage requirements, feel free to submit a PR to add support. You can find details in the CONTRIBUTING.md file.

@lildude lildude changed the title Add support for .Containerfile extension Add support for .containerfile extension Apr 17, 2024
@gnat
Copy link
Author

gnat commented Apr 17, 2024

Linguist already supports Containerfile as an alias of Dockerfile 👀

Containerfile is just the standard OCI name

@lildude
Copy link
Member

lildude commented Apr 17, 2024

Indeed. But it's not going to magically appear in the languages.yml file without a PR, and support won't be added until usage meets our requirements. This applies to all additions for new and existing languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants