Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake syntax needs replacing #6659

Closed
petk opened this issue Dec 28, 2023 · 7 comments · Fixed by #7060
Closed

CMake syntax needs replacing #6659

petk opened this issue Dec 28, 2023 · 7 comments · Fixed by #7060
Assignees

Comments

@petk
Copy link

petk commented Dec 28, 2023

Describe the bug

Basically any modern CMake code on GitHub is not rendered properly anymore. I understand that there is upstream repository that holds the syntax, but can this be sorted somehow differently? That repository hasn't been updated in nearly 8 years and I doubt it will get any update in any near future.

https://github.com/textmate/cmake.tmbundle

@petk petk added the Bug label Dec 28, 2023
@lildude lildude added Improvement and removed Bug labels Dec 28, 2023
@lildude
Copy link
Member

lildude commented Dec 28, 2023

You're welcome to submit a PR to change the grammar 😉

@lildude lildude changed the title Please fix CMake syntax CMake syntax needs replacing Dec 28, 2023
@lildude
Copy link
Member

lildude commented Dec 28, 2023

These also an issue with the highlighting engine which came to light last week… changing grammars won't solve that problem and it's also likely to be what's causing problems now if this only recently became an issue.

@petk
Copy link
Author

petk commented Dec 28, 2023

Yeah, I could open a PR on the mentioned repository. But if someone is already familiar with all these software used here that would be really nice and much more faster resolved. The reason I'm opening this discussion is based on the inactivity of the upstream repo also. That's why. Because we know how opening some PR on a dead repository goes.

@lildude
Copy link
Member

lildude commented Dec 29, 2023

I was referring to opening a PR on this repo to change the grammar we use to one that is actively maintained and doesn't exhibit the problems you are seeing. Linguist is a community-supported project and relies almost entirely on user contributions as it's impossible to know every language supported well enough to know what is expected and what isn't.

@lildude
Copy link
Member

lildude commented Jan 2, 2024

I've opened #6668 to track the highlighting issues in one place

@nilason
Copy link

nilason commented May 10, 2024

I have just submitted a PR textmate/cmake.tmbundle#7 to add support for CMake bracket comments. Considering the low activity upstream (and the likelihood for it to be merged anytime soon), you are free to use https://github.com/nilason/cmake.tmbundle/tree/fix_multiline_comment.

I use this with TextMate, so I'm curious to know what else is missing.

@petk
Copy link
Author

petk commented Nov 25, 2024

Thank you @lildude This is really nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants