Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify better -destination in build-xcframework.sh #4153

Open
armcknight opened this issue Jul 10, 2024 · 1 comment
Open

Specify better -destination in build-xcframework.sh #4153

armcknight opened this issue Jul 10, 2024 · 1 comment

Comments

@armcknight
Copy link
Member

Description

currently we specify the -sdk to xcodebuild, but this is a fragile approach and should be replaced with -destination. Currently, it is warning that it will choose the first from a set of possible destinations, and this can sometimes lead to it choosing the wrong one. I've seen this happen when it chooses a macOS destination when building for iOS, and also choosing the wrong macOS architecture (x86_64 vs arm64).

https://github.com/getsentry/sentry-cocoa/actions/runs/9866174689/job/27244481851#step:3:3981

image
@brustolin
Copy link
Contributor

For macOS catalyst we use -destination and the same warning appears.
I believe the solution should involve a query for the specific SDK before compiling it, to ensure the desire destination exists.

@brustolin brustolin moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants