-
-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Out of Memory Crash Report Has Incorrect User Id #1152
Comments
Hey @jimrutherford, thanks for reaching out. The SDKs uses However, when do you call |
Just an idea, what if you only wrote to disk when |
Thanks for the input, @CraigSiemens, but the problem is that there is no guarantee to receive We could only put data to an OOM crash that we are sure is accurate. This would mean less data, but we wouldn't confuse our users. |
We can store some information to disk when receiving an Another possible solution is to persist the scope periodically to disk, which a scope change, some time interval, or an event to be defined can trigger. As this is going to cause more I/O, the SDK could offer a feature flag. Helpful information to attach to the OOM:
|
It sounds like we need to clarify how this works on the troubleshooting page of the docs. Perhaps suggestion a BeforeSend solution where the user can manage persisting data and setting to the event after restart. |
As @bruno-garcia said, we should communicate better in the docs getsentry/sentry-docs#4499 what an OOM on Apple is. We should build awareness that this is not a standard issue. |
We could solve this problem by implementing the setUser scope observer here sentry-cocoa/Sources/Sentry/SentryWatchdogTerminationScopeObserver.m Lines 157 to 160 in 4af7581
sentry-cocoa/Sources/Sentry/SentryWatchdogTerminationTracker.m Lines 63 to 64 in 4af7581
|
Environment
How do you use Sentry?
Sentry SaaS (sentry.io)
Which SDK and version?
Swift 7.0.3
Steps to Reproduce
User.id
value does not match User.id value as set bySentrySDK.setUser(...)
Expected Result
I expect that the value I set as the user id for the sentry session would appear in OOM crash reports. We have over 100 OOM crashes affecting 92 users and none of the 92 users match any user id's in our user database. All other non-OOM crash reports we observe have user id's that match users in our database.
Actual Result
We are observing that for OOM crash reports, reported user ids do not match any user id's in our database.
The text was updated successfully, but these errors were encountered: