Fixing some minor SonarQube findings

Author: entorb

Dockerfile

@@ -11,7 +11,19 @@ ENV DEBIAN_FRONTEND=noninteractive
 
 # install packages and cleanup afterwards
 RUN apt-get update && apt-get dist-upgrade -y && \
-    apt-get install -y python3 python3-lxml git texlive-xetex texlive-lang-greek texlive-lang-german latexmk texlive-extra-utils pandoc calibre imagemagick ghostscript && \
+    apt-get install -y \
+    calibre \
+    ghostscript \
+    git \
+    imagemagick \
+    latexmk \
+    pandoc \
+    python3 \
+    python3-lxml \
+    texlive-extra-utils \
+    texlive-lang-german \
+    texlive-lang-greek \
+    texlive-xetex && \
     apt-get clean autoclean && apt-get autoremove --yes && rm -rf /var/lib/{apt,dpkg,cache,log}/
 
 # set working directory

scripts/ebook/step_3.py

@@ -99,7 +99,7 @@
 
     # remove all images
     cont = re.sub(
-        r"\\includegraphics\[.*?\]\{.*?\}",
+        r"\\includegraphics\[[^\]]*\]\{[^\}]*\}",
         "",
         cont,
         flags=re.DOTALL,

scripts/ebook/step_4.py

@@ -17,7 +17,7 @@
 
 def convert_parsel(s: str) -> str:
     """Convert text to Parsel."""
-    # TODO: for spellcheck doc version we should return here
+    # for spellcheck of .doc version we should return here
     # return s
     # small ss -> ß -> sss ; s->ss
     s = s.replace("ss", "ß").replace("s", "ss").replace("ß", "sss")

scripts/ebook/step_6.py

@@ -25,7 +25,7 @@ def check_html(cont: str) -> None:
     """Check html syntax."""
     parser = etree.XMLParser(recover=False)  # Do not auto-fix errors
     try:
-        etree.fromstring(cont, parser)  # noqa: S320
+        etree.fromstring(cont, parser)
     except etree.XMLSyntaxError as e:
         print("HTML Error:", e)
         sys.exit(1)

scripts/ebook/v1/1_latex2html.py

@@ -785,6 +785,6 @@ def find_tex_commands(s: str) -> list:
 ):
     print(f"{value}\t{key}")
 
-assert (
-    len(d_tex_commands_unhandled) == 0
-), "Error: unhandled LaTeX commands found, see above"
+assert len(d_tex_commands_unhandled) == 0, (
+    "Error: unhandled LaTeX commands found, see above"
+)