Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

neofetch doesn't report the correct display resolution #1589

Open
odebroqueville opened this issue Oct 27, 2020 · 6 comments
Open

neofetch doesn't report the correct display resolution #1589

odebroqueville opened this issue Oct 27, 2020 · 6 comments
Labels

Comments

@odebroqueville
Copy link

Description

neofetch doesn't report the correct display resolution for my 5K iMac. The resolution reported should be 5120x2880 (Retina) instead of 2560x1440.

  • [Y] Does this issue still occur in the master branch? (Required if issue)

Neofetch version

neofetch version 7.1.0

Screenshot

Screenshot 2020-10-27 at 20 26 01

Config file

https://pastebin.com/pwGb2Ade

Verbose log

https://pastebin.com/7jq2L0kh

@alobbs
Copy link

alobbs commented Nov 29, 2020

Wrong resolution in OSX as well:
Screen Shot 2020-11-29 at 10 21 10 AM

@dylanaraps dylanaraps added the Bug label Jun 11, 2021
@Fr1tzBot
Copy link
Contributor

Fr1tzBot commented Jun 12, 2021

For me at least (on an m1 running big sur), neofetch (the latest master version) reports the scaled resolution of 1440x900 (preferences > displays) instead of the actual screen resolution of 2560x1600 (about this mac > displays)
image
image
image

Edit: after digging into the code a bit, this appears to be a difference between using screenresolution and system_profiler to find the res, with screenresolution reporting the scaled resolution and system_profiler reporting the true resolution

This could maybe be fixed by using system_profiler as the default rather than screenresolution on lines 3007-3016

@dylanaraps
Copy link
Owner

screenresolution is default as system_profiler was (in the past) deemed too slow. Is this still the case?

@Fr1tzBot
Copy link
Contributor

Here are the times that I recorded:

image

times including some of the processing from the code:

image

times for the full program (first is screenresolution , second is system_profiler):

image

@dylanaraps
Copy link
Owner

Neofetch seems to be slow overall on macOS.

@odebroqueville
Copy link
Author

@Fr1tzBot Thank you ! I changed the code in neofetch to the following:

Screenshot 2022-02-19 at 18 26 15

I now get the following result (which is cool!):

Screenshot 2022-02-19 at 18 33 09

I couldn't get the refresh rate (Hz) though!

@dylanaraps Would be nice to have a flag to chose between screenresolution and system_profiler for those of us who aren't in a hurry!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants