Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ban on wire protocol error[s] #774

Open
dajohi opened this issue Sep 26, 2016 · 1 comment
Open

Ban on wire protocol error[s] #774

dajohi opened this issue Sep 26, 2016 · 1 comment
Assignees

Comments

@dajohi
Copy link
Member

dajohi commented Sep 26, 2016

btcd should ban hosts that do not follow the wire protocol. For developers needing to test, a --whitelist option should be available.

@dajohi dajohi self-assigned this Sep 26, 2016
@Roasbeef
Copy link
Member

We'd want to be careful to ensure that peers which send us new wire messages we don't yet understand are exempt from this banning. With the addition of BIP 151, peers may attempt to optimistically set up an encrypted session within the active connection before version negotiation. If we ban based on an unknown message (since we haven't implemented this yet), then we'd erroneously be dropping peers within the network that support the new encryption features. FWIW, the only implementation I'm aware of that has implemented BIP 151 is bcoin.

On a related, note it's puzzling as to why BIP 151 didn't include a new service bit, or a bump in p2p protocol version. Either of those signals would avoid the scenario of a peer sending a message to another peer with uncertainty as to if they're able to process/recognize the message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants