Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send subscribed tx notifications in block connected notification #602

Open
jrick opened this issue Jan 19, 2016 · 1 comment
Open

Send subscribed tx notifications in block connected notification #602

jrick opened this issue Jan 19, 2016 · 1 comment

Comments

@jrick
Copy link
Member

jrick commented Jan 19, 2016

This will be required for upcoming changes to btcwallet to the processing of transaction notifications.

I'll begin work on this and create a PR, but it will be a breaking API change (no more recvtx/redeemingtx notifications for transactions from an attached block) and can't be merged until the wallet changes are ready.
@jrick
Copy link
Member Author

jrick commented Jan 19, 2016

I'd also like to note that while btcwallet can attempt to combine all of these notifications into a single one so it can process one block at a time, besides being totally silly (why combine what was already combined earlier) I'm not even sure it's possible to do in all cases since transaction notifications from the rescan also make use of the same recvtx/redeemingtx notifications. My change will leave those be, and wallet will treat them as loose transactions not associated with the attached block notification.

jrick added a commit to jrick/btcd that referenced this issue Jan 19, 2016
@jrick
rpcserver: Include txs in blockconnected notifications.
ee1ec14 
This is a breaking change as it removes the recvtx/redeemingtx
notifications for transactions from blocks attached to the main chain.

Fixes btcsuite#602.
jrick added a commit to jrick/btcd that referenced this issue Jan 19, 2016
@jrick
rpcserver: Include txs in blockconnected notifications.
00a844b 
This is a breaking change as it removes the recvtx/redeemingtx
notifications for transactions from blocks attached to the main chain.

Fixes btcsuite#602.
@jrick jrick mentioned this issue Jan 19, 2016
Closed
jrick added a commit to jrick/btcd that referenced this issue Mar 11, 2016
@jrick
rpcserver: Include txs in blockconnected notifications.
29da410 
This is a breaking change as it removes the recvtx/redeemingtx
notifications for transactions from blocks attached to the main chain.

Fixes btcsuite#602.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrick