Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitcoin ordinal inscription encode script with small number #1965

Open
ee07b415 opened this issue Apr 3, 2023 · 0 comments
Open

Bitcoin ordinal inscription encode script with small number #1965

ee07b415 opened this issue Apr 3, 2023 · 0 comments

Comments

@ee07b415
Copy link

ee07b415 commented Apr 3, 2023

From the bitcoin ordinal code example:
https://github.com/casey/ord/blob/938b5cc97d48d026fd9250eae661d1e87286b377/src/inscription.rs#L439
we will need to push []byte{1} as a mark for contentType for bitcoin inscription, but current script builder AddData will convert this into small number OPcode
AddData
So in the encode string, instead of 0101(data length 1, data 1) the builder will encode this into 0x51(OP_01)

I'm not sure if we will support the bitcoin ordinal inscription in the future, a push_exact_data would be preferred here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant