Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connmgr: update TorLookupIP to support parsing IPv6 addresses #1835

Open
Roasbeef opened this issue Mar 30, 2022 · 0 comments · May be fixed by #1876
Open

connmgr: update TorLookupIP to support parsing IPv6 addresses #1835

Roasbeef opened this issue Mar 30, 2022 · 0 comments · May be fixed by #1876

Comments

@Roasbeef
Copy link
Member

Today if the TorLookupIP is used to resolve a hostname, and the first IP returned is actually IPv6, then we'll end up erroring out here:

return nil, ErrTorInvalidAddressResponse
.

We should update this method to support IPv6 parsing by checking the length response, and parsing an IPv6 address accordingly. This python code may prove to be useful during implementation: https://github.com/torproject/tor/blob/main/contrib/client-tools/tor-resolve.py#L49.

@Crypt-iQ Crypt-iQ linked a pull request Aug 11, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant