Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txscript: update ComputePkScript for a post taproot environment #1817

Open
Roasbeef opened this issue Feb 25, 2022 · 0 comments
Open

txscript: update ComputePkScript for a post taproot environment #1817

Roasbeef opened this issue Feb 25, 2022 · 0 comments

Comments

@Roasbeef
Copy link
Member

On the neutrino side, we started to use ComputePkScript to derive a pkScript based on the input witness of a txin. Post taproot, some of the assumptions we made are now incorrect, as an example: a valid taproot witness can be just a single element (the sig for a keypath spend).

On the neutrino side we've simply stopped using this function in the short term. In the medium term we should look into examning some of the new more concrete patters we can match un, as detailed by sipa in this comment: lightninglabs/neutrino#234 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant