Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simnet rejects transactions based on 'priority' #1593

Open
DariusParvin opened this issue Jun 12, 2020 · 2 comments
Open

simnet rejects transactions based on 'priority' #1593

DariusParvin opened this issue Jun 12, 2020 · 2 comments

Comments

@DariusParvin
Copy link

DariusParvin commented Jun 12, 2020

Currently, btcd rejects transactions based on their priority. e.g.
"<txid> has insufficient priority (0 <= 5.76e+07)"

I believe this is an outdated method for rejecting transactions that's not widely used anymore.

I'm not sure if btcd on mainnet mode uses the same 'priority' criteria, but ideally this would be updated to match the latest default bitcoin core standardness rules.

@DariusParvin
Copy link
Author

Related to this, I'm finding that CPFP doesn't always work at bumping up a transaction into the next block. This is because even if the new fee rate is higher than the other transactions in the mempool, it might still have a lower 'priority', e.g. if the other pending transactions are all of a much higher value.

@Roasbeef
Copy link
Member

Related to this, I'm finding that CPFP doesn't always work at bumping up a transaction into the next block.

The simnet miner doesn't implement CPFP as defined.

You're correct that Bitcoin Core has done away with priority for the most part, but its still present in our miner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@Roasbeef @DariusParvin and others