Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease SegWit activation height on regtest #1504

Open
alexbosworth opened this issue Dec 7, 2019 · 5 comments
Open

Decrease SegWit activation height on regtest #1504

alexbosworth opened this issue Dec 7, 2019 · 5 comments
Labels

Comments

@alexbosworth
Copy link
Contributor

For tests, it would be helpful if SegWit could be utilized on regtest with fewer blocks mined

@jakesylvestre
Copy link
Collaborator

I think if we did this it'd need to be a variable/config override

@alexbosworth
Copy link
Contributor Author

I think Bitcoin Core did something similar for their regtest but I don't know the details

@alexbosworth
Copy link
Contributor Author

Are there still people testing non-SegWit things? Why not just activate it from the start like Signet

@jakesylvestre
Copy link
Collaborator

jakesylvestre commented Mar 9, 2021

It would appear regtest is always active on bitcoin-core: https://github.com/bitcoin/bitcoin/blob/5961b23898ee7c0af2626c46d5d70e80136578d3/src/chainparams.cpp#L295 There's a discussion on another client here: stratisproject/StratisBitcoinFullNode#1028. I woudn't be opposed to activating it from the start if you want to submit a pr.

@Roasbeef/@jcvernaleo - lmk if you have any objections here. I really can't think of any

Honestly, we could probably implement this in #1692

@jcvernaleo
Copy link
Member

I have no objection. Makes a lot of sense to me actually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants