Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add miningaddr argument in generate #1411

Open
wbobeirne opened this issue Mar 28, 2019 · 2 comments · May be fixed by #1441
Open

Add miningaddr argument in generate #1411

wbobeirne opened this issue Mar 28, 2019 · 2 comments · May be fixed by #1441

Comments

@wbobeirne
Copy link

I'm working on a little testing tool for simnet & lnd nodes, and it would be extremely convenient if you could specify a miningaddr on the fly per generate, rather than at startup. I'm trying to make it easy to fund nodes quickly, but due to miningaddr only being configurable as a btcd argument, I would have to restart btcd each time to fund a node.

Ideally I'd instead like to generate a new address from the node, and generate a block with a command like btcctl generate 1 --miningaddr=[result from lncli newaddress here]. I'm not sure how generate and miningaddr are put together, but hopefully this wouldn't be too difficult.

@darwin
Copy link
Contributor

darwin commented Apr 24, 2019

I would like to see this as well. But I would suggest not touching generate and instead implementing generatetoaddress behaving the same as in bitcoin-cli.

I work on a testing tool for simnet clusters and I want to support both btcd/bitcoind as master backend node for mining into a faucet. Currently I have to branch the code (and have prior miningaddr config in btcd case).

https://github.com/darwin/simverse/blob/551b896c16aab7870520c3fbd5c3782bd2b40ab3/toolbox/generate#L8-L12

@Roasbeef
Copy link
Member

Related to #845

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants