Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpcclient: Use btcutil.Address type in all interfaces #1127

Open
gracenoah opened this issue Feb 20, 2018 · 1 comment
Open

rpcclient: Use btcutil.Address type in all interfaces #1127

gracenoah opened this issue Feb 20, 2018 · 1 comment

Comments

@gracenoah
Copy link
Contributor

Right now ImportAddress and some other functions take address as a string while ListUnspentMinMaxAddressesAsync and most other functions take it as btcutil.Address.

Everything function should take btcutil.Address in its interface for type safety.

See also
@gracenoah gracenoah mentioned this issue Feb 20, 2018
Closed
@stevenroose
Copy link
Contributor

I agree. I'll take this into account for my gRPC implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change string to address type in rpcclient interface gracenoah/btcd
2 participants
@stevenroose @gracenoah