rpcClient: GetRawChangeAddress is broken with bitcoin core 0.15

[FrozenPrincess]

It previously took in an "account" and no longer does (and gives a hard error if you pass in anything)

[stevenroose]

I think it's weird that the RPC method for btcwallet are now part of btcd inside btcrpcclient. Is being API compatible with Core worth it? I mean maintaining a satoshirpcclient would not be that much work for the people in need of it.

[davecgh]

I have been considering dropping support for Core. It constantly changes the RPC API and doesn't have any versioning associated with it. The reason this fails is because they removed the account parameter, which btcwallet needs, so it can't be removed.

You can create a local function in the calling code similar to the following to get around it though:

func getRawChangeAddress(c *rpcclient.Client) (btcutil.Address, error) {
	rawResp, err := c.RawRequest("getrawchangeaddress", nil)
	if err != nil {
		return nil, err
	}
	var addrStr string
	err = json.Unmarshal(rawResp, &addrStr)
	if err != nil {
		return nil, err
	}
	addr, err := btcutil.DecodeAddress(addrStr, chainParams)
	if err != nil {
		return nil, err
	}
	if !addr.IsForNet(chainParams) {
		return nil, fmt.Errorf("address %v is not intended for use on %v",
			addrStr, chainParams.Name)
	}
	return addr, nil
}

[stevenroose]

I'd be in favor of that. In that case, we could move all the wallet methods to btcwalllet/walletrpcclient or similar and it's clear what methods will work on what application.

[jrick]

The trouble is these methods are used in btcctl, which lives in btcd, and btcctl needs to implement the wallet methods.

[stevenroose]

Hmm. What a mess. walletctl would be aweful, or would it?