fix: await AppSyncEvent WebSocket connection establishment #14438
+59
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR fix the race condition between web socket connection and subsequent publish event while using AppSyncEvents.
Before this change, the web socket connection Promise is resolve while the connection is still being established. It allows subsequent publish event calls to the web socket connection is ready.
Now the web socket connection Promise will be resolved only when the connection is established completely.
Issue #, if available
Description of how you validated changes
Run unit, E2E tests and verified manually that WebSocket connection is established before any event is being published.
Checklist
yarn test
passesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.