Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request]: Can you make a release after the 1.82 fixes #2444

Open
1 task done
happysalada opened this issue Nov 12, 2024 · 5 comments
Open
1 task done

[Request]: Can you make a release after the 1.82 fixes #2444

happysalada opened this issue Nov 12, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@happysalada
Copy link

What did you expect to happen?

working package in nixpkgs

What happened?

the last release is broken with rust 1.82, that means that the package in nixpkgs is broken

Atuin doctor output

I completely realise that atuin is not at fault here. It would be nice to have another release, but no worries if you are busy.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@happysalada happysalada added the bug Something isn't working label Nov 12, 2024
@ellie
Copy link
Member

ellie commented Nov 14, 2024

Definitely looking to get a release out soon as it's been WAY too long, there's a couple of serverside adjustments I need to make to our deployment first though.

I'm a little concerned that the package in nix no longer builds though, surely all the deps are pinned?

@happysalada
Copy link
Author

The deps are pinned, but only a single version of rustc is used to prevent dependency explosion, so right now on everything is on rust 1.82 and atuin doesnt compile on latest master. Its not a big deal, people on unstable know what they are signing for, but i just thought i might put a request for a new release.
No rush, take the time you need to do things right !

@eric-hansen
Copy link

eric-hansen commented Nov 15, 2024

It's bee na while since I had to deal w/ the Nix/Rust thing, but wouldn't either a devenv or devShell derivation solve the issue with compiling? could make it part of the preInstall build step (I think). Then just have a Rust input locked to a specific nixpkgs commit where the non-broken build can happen.

@happysalada
Copy link
Author

The package failing is on nixpkgs, so you cant just use any rust version you have to use the one provided by nixpkgs.
Its not a major problem, the release will be appreciated when you have time.

@happysalada
Copy link
Author

Friendly bump on making a new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants