Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make max number of search results configurable #1821

Open
dajoha opened this issue Mar 4, 2024 · 1 comment
Open

Make max number of search results configurable #1821

dajoha opened this issue Mar 4, 2024 · 1 comment

Comments

@dajoha
Copy link

dajoha commented Mar 4, 2024

It seems that the maximum number of search results in the TUI is hardcoded here:

.list(&[state.filter_mode], &state.context, Some(200), true, false)

It would be great if it was configurable in the toml file, for example with the key max_results.

If some people feel it's a good idea, I can work on a PR to implement it.

BTW, thank you for this awesome project!

@ellie
Copy link
Member

ellie commented Mar 8, 2024

It would be great if it was configurable in the toml file

What use case would this solve?

I'm ok with making changes like this, but would like to have a solid problem in mind that we're trying to solve.

If users are scrolling back through 200+ entries, then that's a failure of search. I don't think the solution there is letting them scroll further, at the cost of slowing down searching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants