Fix false positive for Apache-2.0 OR BSD-3-Clause and add Apache-2.0 … #4126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pombredanne
requested changes
Feb 26, 2025
There was a problem hiding this comment.
Thanks. You are missing a DCO signoff, and should start by adding a test. Do not update existing rules with different texts. Create new ones, and check https://aboutcode.readthedocs.io/en/latest/contributing/writing_good_commit_messages.html
| @@ -1,11 +1,11 @@ | |||
| --- | |||
| license_expression: apache-2.0 OR bsd-new | |||
| is_license_notice: yes | |||
| relevance: 99 | |||
| relevance: 100 | |||
There was a problem hiding this comment.
Do not change this. How can you be 100% sure that LICENSE.BSD contains a bsd-new
| found in {{LICENSE.APACHE}} or {{LICENSE.BSD}}. Both must be present for this rule to apply. |
There was a problem hiding this comment.
Do not change existing rules. Create new ones
| This software is made available under the terms of *either* of the licenses | ||
| found in LICENSE.APACHE2 or LICENSE.MIT. |
There was a problem hiding this comment.
Do not change existing rules. Create new ones
| ignorable_urls: | ||
| - http://opensource.org/licenses/MIT | ||
| - http://www.apache.org/licenses/LICENSE-2.0 | ||
| - LICENSE.APACHE2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…OR MIT rule
Fixes #4088
Tasks
Run tests locally to check for errors.